[PATCH] nss_wrappe fix comparison between pointer and '\0'

Andreas Schneider asn at samba.org
Wed Aug 16 09:35:03 UTC 2017

On Wednesday, 16 August 2017 01:12:54 CEST Douglas Bagnall via samba-technical 
> hi Gary,
> On 16/08/17 07:04, Gary Lockyer via samba-technical wrote:
> > fixes GCC 7.1 warning, pointers being compared to '\0' without a
> > dereference.
> > 
> > Review appreciated.
> I actually found this a while ago and Andreas reminded me to patch
> against the upstream nss_wrapper repository:
> https://lists.samba.org/archive/samba-technical/2017-July/121750.html
> I gave that task a non-urgent priority. It turns out I was waiting for
> you to prompt me. My attached version is slightly different,
> explicitly ignoring an empty string.

Hi Gary and Douglas,

I've fixed that last week, but do not have a RB+ for the patch yet. I think 
the if-check for strtol should be as in the attached patch.

Do you agree?


Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             asn at samba.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-nwrap-Fix-check-after-strtol.patch
Type: text/x-patch
Size: 825 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20170816/0bdd96e0/0001-nwrap-Fix-check-after-strtol.bin>

More information about the samba-technical mailing list