[PATCH] Missing tidyup for bug #12932

Stefan Metzmacher metze at samba.org
Mon Aug 14 22:20:44 UTC 2017


Am 14.08.2017 um 22:11 schrieb Jeremy Allison:
> Metze pointed out in the bug report backport
> that I incorrectly used the Samba internal
> talloc.h header instead of the system one.
> 
> Please review and push if happy !

Looks good.

Do you have time to also cleanup the remaining onces (not introduced by
you)?

$ git grep '"lib/tevent/tevent.h"'
lib/async_req/async_connect_send_test.c:#include "lib/tevent/tevent.h"
lib/tevent/testsuite.c:#include "lib/tevent/tevent.h"
source4/librpc/rpc/dcerpc_roh_channel_in.c:#include "lib/tevent/tevent.h"
source4/librpc/rpc/dcerpc_roh_channel_out.c:#include "lib/tevent/tevent.h"
source4/torture/smb2/rename.c:#include "lib/tevent/tevent.h"
source4/torture/smb2/sharemode.c:#include "lib/tevent/tevent.h"

$ git grep '"lib/talloc/talloc.h"'

source4/lib/com/com.h:#include "lib/talloc/talloc.h"
source4/lib/wmi/wbemdata.c:#include "lib/talloc/talloc.h"
source4/librpc/rpc/dcerpc_roh_channel_in.c:#include "lib/talloc/talloc.h"
source4/librpc/rpc/dcerpc_roh_channel_out.c:#include "lib/talloc/talloc.h"
testprogs/win32/spoolss/testspoolss.h:#include "lib/talloc/talloc.h"

Thanks!
metze

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20170815/94979c3f/signature.sig>


More information about the samba-technical mailing list