[[PATCH v1] 00/37] Implement SMBD protocol: Series 1
longli at microsoft.com
Mon Aug 14 17:04:00 UTC 2017
> -----Original Message-----
> From: Christoph Hellwig [mailto:hch at infradead.org]
> Sent: Sunday, August 13, 2017 3:28 AM
> To: Long Li <longli at microsoft.com>
> Cc: Steve French <sfrench at samba.org>; linux-cifs at vger.kernel.org; samba-
> technical at lists.samba.org; linux-kernel at vger.kernel.org; Long Li
> <longli at microsoft.com>
> Subject: Re: [[PATCH v1] 00/37] Implement SMBD protocol: Series 1
> Hi Long,
> a few meta-comments:
> first the split into lots of tiny lists makes the series really hard to read, I'd split
> it into just a few:
> Patch 1: add the protocol constants
> Patch 2-n: core cifs modifcation required to implement SMBD Patch n+1:
> add the actual SMBD code Patch n+2..m: write up the core CIFS code to use
> stcond a lot of the code doesn't seem to follow the usual Linux style.
> It might be a good idea to run it through scripts/checkpach.pl and at least fix
> the errors it generates. The warnings are much more opinioned so feel free
> to ignore them if they sound odd for now.
Thank you for reviewing the patch set.
I'll address those comments and update the patches.
More information about the samba-technical