[PATCH] CTDB scripting cleanup, including shellcheck fixups/avoidance

[Martin Schwenke]

Shell script cleanups, mostly to handle some new shellcheck hits that
appeared with the latest version of shellcheck.  Also, fixes for some
other issues we have noticed.

There is still one failure when running CTDB's shellcheck testsuite,
due to a regression in shellcheck:

  https://github.com/koalaman/shellcheck/issues/950

The fix has been merged.  Just avoid shellcheck versions 0.4.5 and
0.4.6 when running against CTDB.  ;-)

CTDB's shellcheck testsuite still excludes several shellcheck codes.
These appeared some time ago and were too painful to deal with.
Hopefully I'll do something about them some time.

Please review and maybe push...

peace & happiness,
martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ctdb.patch
Type: text/x-patch
Size: 10080 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20170811/8e269031/ctdb.bin>