Please use "error and out" logic (Re: [PATCH] Avoid privileged segfault in GetNCChanges and add many more tests)

Stefan Metzmacher metze at
Thu Aug 10 11:00:19 UTC 2017

Hi Andrew,

>> Can we please agree on using an "error and out logic" for new code?
>> There's really no good reason to have the additional indentation
>> for the "sid = pytalloc_get_ptr(py_sid);" line!
>> I thought this was part of README.Coding for a long time already,
>> but I can't find it...
> Sure.  I'm happy to fix this up.
> I'll work with Gary to fix this one up.

Thanks! Please keep that in mind for future coding and review,
it'll make the life easier for all of us in the end.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <>

More information about the samba-technical mailing list