Fwd: Re: [PATCHES] GPO support for the AD DC itself

David Mulder dmulder at suse.com
Wed Aug 9 18:34:52 UTC 2017


Hey,

So I went ahead and squashed the unapply and tdb storage commits
together, which required extracting pieces of the always apply patch. I
renamed the tdb file to gpo.tdb throughout the history, and I pulled in
my patch that fixes the unapply (which I broke earlier when rebasing).
This is all based on top of Garming's rebase work, so it's all in there.
Thanks for your help Garming, the patches are looking great!
Patches are attached.

On 08/08/2017 10:47 PM, Garming Sam wrote:
> Hi,
>
> I've taken a look at the patches, and they needed a lot of squashing
> in my mind. It seemed easier to just do it than explain at length all
> the details. The overall patchset result stays the same, but a lot of
> the intermediate steps have now been removed. The Kerberos patches in
> particular have been disentangled from the middle of the patchset.
> Unless you had any objections or other things to add, I will look to
> squashing the unapply code together with the tdb storage. The
> syslog.tdb (and sysvol_log.tdb) which appeared at various points also
> need to be renamed to gpo.tdb for continuity.
>
> Apart from that, the changes don't look all that overwhelming anymore
> and I'm happier with them. It should also be much clearer for Andrew
> to look at now.
>
>
> Cheers,
>
> Garming
>

-- 
David Mulder
SUSE Labs Software Engineer - Samba
dmulder at suse.com
SUSE Linux GmbH, GF: Felix Imend├Ârffer, Jane Smithard, Graham Norton, HRB 21284 (AG N├╝rnberg)

-------------- next part --------------
A non-text attachment was scrubbed...
Name: gpo.mbox
Type: application/mbox
Size: 148338 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20170809/1e526b95/gpo-0001.mbox>


More information about the samba-technical mailing list