[PATCH] Fix 'net ads changetrustpw'

Rowland Penny rpenny at samba.org
Wed Aug 9 17:03:34 UTC 2017


On Wed, 09 Aug 2017 18:45:10 +0200
Andreas Schneider via samba-technical <samba-technical at lists.samba.org>
wrote:

> Hi,
> 
> as always, untested code is broken code. So I broke 'net ads
> changetrustpw' in Samba 4.6.
> 
> The attached patch fixes the issue and adds a tests which verifies
> that it is working.
> 
> 
> Please review and push if OK.
> 
> 
> Thanks,
> 
> 
> 	Andreas
> 

OK, I asked Andrew this and got a very non committal answer, so this
seems to a good place to ask everyone, why does Samba use the ancient
backticks ?

i.e `expr $failed + 1` instead of $((failed + 1))

Rowland
 



More information about the samba-technical mailing list