Please use "error and out" logic (Re: [PATCH] Avoid privileged segfault in GetNCChanges and add many more tests)
simo at samba.org
Wed Aug 9 16:31:34 UTC 2017
On Wed, 2017-08-09 at 15:42 +0200, Ralph Böhme via samba-technical
> On Wed, Aug 09, 2017 at 03:26:29PM +0200, Ralph Böhme via samba-
> technical wrote:
> > On Wed, Aug 09, 2017 at 09:10:22AM -0400, Simo via samba-technical
> > wrote:
> > > Thanks metze,
> > > readability and modifiability of code are very important, and
> > > become
> > > even more important as a project grows and ages.
> > >
> > > It would be nice to add a style section to the docs that more
> > > forcefully and clearly explain these subtle coding style issues.
> > patch attached.
> updated version removing the unrelated hunk. Sorry!
still RB by me
More information about the samba-technical