[PATCH] Fix Samba build

Andreas Schneider asn at samba.org
Wed Aug 9 05:47:40 UTC 2017


Hi,

review and push much appreciated.


Thanks,


	Andreas

-- 
Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             asn at samba.org
www.samba.org
-------------- next part --------------
From 5a72e6e325be2315c0d6b6cc2cfb63a83bffa276 Mon Sep 17 00:00:00 2001
From: Andreas Schneider <asn at samba.org>
Date: Wed, 9 Aug 2017 07:45:04 +0200
Subject: [PATCH] s4:samdb: Fix building Samba with -O3
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

gcc error: ‘result’ may be used uninitialized

This wont happen, because ldb will return and error, but the compiler
doesn't understand this.

Signed-off-by: Andreas Schneider <asn at samba.org>
---
 source4/dsdb/samdb/ldb_modules/vlv_pagination.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/source4/dsdb/samdb/ldb_modules/vlv_pagination.c b/source4/dsdb/samdb/ldb_modules/vlv_pagination.c
index 5b744e3c181..980177cb05e 100644
--- a/source4/dsdb/samdb/ldb_modules/vlv_pagination.c
+++ b/source4/dsdb/samdb/ldb_modules/vlv_pagination.c
@@ -436,7 +436,7 @@ static int vlv_results(struct vlv_context *ac)
 			     ac->store->num_entries - 1);
 
 		for (i = first_i; i <= last_i; i++) {
-			struct ldb_result *result;
+			struct ldb_result *result = NULL;
 			struct GUID *guid = &ac->store->results[i];
 
 			ret = vlv_search_by_dn_guid(ac->module, ac, &result, guid,
-- 
2.13.3



More information about the samba-technical mailing list