[PATCH] Small winbind improvements

Richard Sharpe realrichardsharpe at gmail.com
Mon Aug 7 02:31:52 UTC 2017


On Sun, Aug 6, 2017 at 7:26 PM, Richard Sharpe
<realrichardsharpe at gmail.com> wrote:
> 2017-08-06 2:30 GMT-07:00 Volker Lendecke via samba-technical
> <samba-technical at lists.samba.org>:
>> Hi!
>>
>> Review appreciated!
>>
>> Thanks, Volker
>
> Hi Volker,
>
> The first two are no brainers and RB+ but the third one changes the
> sense of the if condition. I will look at it more carefully now.

OK. I agree with the third change (changes from !is_offline to
is_online, which is much easier to understand), so RB+ as well, but I
see Martin has already reviewed and pushed them.

-- 
Regards,
Richard Sharpe
(何以解憂?唯有杜康。--曹操)



More information about the samba-technical mailing list