AW: [PATCH] Fix CID 1415704 Integer overflowed argument

Andrej Gessel Andrej.Gessel at janztec.com
Fri Aug 4 12:59:45 UTC 2017


Hi,

i've looked through last commits on master and maybe found some mistake. Which function should be really used here?
Commit message: strtoul
Commit: strtol

I think strtol, because variable "n", that holds return value of function, is of type long.

Thanks

Andrej

-----Urspr√ľngliche Nachricht-----
Von: samba-technical [mailto:samba-technical-bounces at lists.samba.org] Im Auftrag von Andreas Schneider via samba-technical
Gesendet: Donnerstag, 3. August 2017 10:56
An: samba-technical at lists.samba.org; Volker.Lendecke at sernet.de
Betreff: Re: [PATCH] Fix CID 1415704 Integer overflowed argument

On Sunday, 30 July 2017 17:22:01 CEST Volker Lendecke via samba-technical
wrote:
> On Sat, Jul 29, 2017 at 11:29:14AM +0200, Andreas Schneider wrote:
> > > Are you ok with the attached patchset?
> > 
> > Are you fine with the mentioned patchset? Can I push it so we can 
> > move on and fix it in uid_wrapper and samba source code?
> 
> Yes, sure.

The attached patch adresses CID 1415704 corretly. It has already been applied to the uid_wrapper repository and Coverity reported that the issue has been eliminated.


Review and push appreciated.


Thanks,


	Andreas

-- 
Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             asn at samba.org
www.samba.org


More information about the samba-technical mailing list