[PATCH] Add DNS widkcard support.

[Gary Lockyer]

Updated patch set incorporating Andrews and Volkers feedback.

Reviews appreciated.

Gary



On 27/07/17 18:10, Volker Lendecke wrote:
> On Thu, Jul 27, 2017 at 03:31:01PM +1200, Andrew Bartlett via samba-technical wrote:
>> On Thu, 2017-07-27 at 14:00 +1200, Gary Lockyer via samba-technical
>> wrote:
>>> Patches to add support for DNS wild card records.
>>>
>>> Tests validated against Windows server 2012 R2
>>>
>>> Reviews and push appreciated
>>
>> Thanks Gary,
>>
>> My biggest concern here is in the re-parsing of the DN as a string, and
>> then the manipulations required to try and create the wildcard
>> searches. 
>>
>> Can we instead parse this into a struct ldb_parse_tree and use routines
>> like ldb_dn_get_rdn_name() and ldb_dn_get_rdn_val() to work out the
>> bits you want from the original DN, and use LDB_SCOPE_ONELEVEL to
>> ensure you don't look further down the tree than you expect.
>>
>> That should make the string work here seem much more mundane. 
> 
> Also, a bit nit-picking: Passing down boolean flags is always
> completely opaque for the caller. "true" and "false" don't have a
> visible meaning themselves, you will always have to look up what this
> exactly means. Can we make two routines with obvious names for the
> external callers? If absolutely required, they can then pass down a
> flag to an internal routine. But if that can be avoided also, even
> better.
> 
> Thanks, Volker
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-dnsserver-Tests-for-dns-wildcard-entries.patch
Type: text/x-patch
Size: 13926 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20170804/9f1ea863/0001-dnsserver-Tests-for-dns-wildcard-entries.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-dnsserver-Tighten-DNS-name-checking.patch
Type: text/x-patch
Size: 2637 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20170804/9f1ea863/0002-dnsserver-Tighten-DNS-name-checking.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-dnsserver-Add-support-for-dns-wildcards.patch
Type: text/x-patch
Size: 15522 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20170804/9f1ea863/0003-dnsserver-Add-support-for-dns-wildcards.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-samba-tool-dns-query-Allow-in-names.patch
Type: text/x-patch
Size: 1008 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20170804/9f1ea863/0004-samba-tool-dns-query-Allow-in-names.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20170804/9f1ea863/signature.sig>