[PATCH] idmap: remove unused function idmap_is_online()
Christof Schmitt
cs at samba.org
Thu Aug 3 18:54:52 UTC 2017
On Thu, Aug 03, 2017 at 04:21:16PM +0200, Ralph Wuerthner via samba-technical wrote:
> Hello,
>
> please see attached patch to remove unused function idmap_is_online().
>
> Commit fa8f097 winbind: Remove unused idmap_[ug]id_to_sid
> removed all callers of idmap_is_online().
>
> --
> Regards
>
> Ralph Wuerthner
Reviewed-by: Christof Schmitt <cs at samba.org>
> From b66418d3e87f4f907a2e186f35d7459189bb1abf Mon Sep 17 00:00:00 2001
> From: Ralph Wuerthner <ralph.wuerthner at de.ibm.com>
> Date: Tue, 1 Aug 2017 16:40:30 +0200
> Subject: [PATCH] idmap: remove unused function idmap_is_online()
>
> Signed-off-by: Ralph Wuerthner <ralph.wuerthner at de.ibm.com>
> ---
> source3/torture/test_idmap_tdb_common.c | 5 -----
> source3/winbindd/idmap.c | 5 -----
> source3/winbindd/idmap_proto.h | 1 -
> 3 files changed, 11 deletions(-)
>
> diff --git a/source3/torture/test_idmap_tdb_common.c b/source3/torture/test_idmap_tdb_common.c
> index 897d2173..5ecb978 100644
> --- a/source3/torture/test_idmap_tdb_common.c
> +++ b/source3/torture/test_idmap_tdb_common.c
> @@ -57,11 +57,6 @@ bool winbindd_use_idmap_cache(void) {
> return false;
> }
>
> -bool idmap_is_online(void)
> -{
> - return true;
> -}
> -
> static bool open_db(struct idmap_tdb_common_context *ctx)
> {
> NTSTATUS status;
> diff --git a/source3/winbindd/idmap.c b/source3/winbindd/idmap.c
> index 70f35ae..6e70b44 100644
> --- a/source3/winbindd/idmap.c
> +++ b/source3/winbindd/idmap.c
> @@ -304,11 +304,6 @@ bool idmap_is_offline(void)
> get_global_winbindd_state_offline() );
> }
>
> -bool idmap_is_online(void)
> -{
> - return !idmap_is_offline();
> -}
> -
> /**********************************************************************
> Allow a module to register itself as a method.
> **********************************************************************/
> diff --git a/source3/winbindd/idmap_proto.h b/source3/winbindd/idmap_proto.h
> index 596c22f..f4fc2c2 100644
> --- a/source3/winbindd/idmap_proto.h
> +++ b/source3/winbindd/idmap_proto.h
> @@ -28,7 +28,6 @@
> /* The following definitions come from winbindd/idmap.c */
>
> bool idmap_is_offline(void);
> -bool idmap_is_online(void);
> NTSTATUS smb_register_idmap(int version, const char *name,
> struct idmap_methods *methods);
> void idmap_close(void);
> --
> 2.7.4
>
More information about the samba-technical
mailing list