Looks like we do not have self-tests for smbcacls

Noel Power nopower at suse.com
Thu Aug 3 11:41:31 UTC 2017


And another version.....

On 31/07/17 20:34, Andrew Bartlett wrote:
> On Mon, 2017-07-31 at 13:51 +0100, Noel Power via samba-technical
> wrote:
>> Please find a new version of the patchset (with tests re-written in python)
>> Noel
> Thanks for writing these tests.  It would have been better however if
> the tests used the standard test classes like BlackboxTestCase and the
> assertions that go with it.  
>
> I know it will be a pile of pain to re-work the test (again!), but the
> consistency really helps as others will copy and paste from the first
> example they find.
>
> See for example python/samba/tests/blackbox/ndrdump.py
>
> (We used to have more of those, but SambaToolCmdTest took over for
> Samba tests).
>
> Sorry,
>
> Andrew Bartlett


-------------- next part --------------
A non-text attachment was scrubbed...
Name: smbcacls_with_pytest#2.patch
Type: text/x-patch
Size: 101602 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20170803/c3f75f99/smbcacls_with_pytest2.bin>


More information about the samba-technical mailing list