Show-stopper samba-4.7.0rc3 on AIX when using xlc

[Michael Felt]

Hi,

Been working on packaging SAMBA for AIX the last 24 hours. Via the bug 
reports I saw some patches that have been applied to SAMBA-4.7 (but not 
in the 4.4.15.+ I guess) - so started a test of the rc as well.

It stops almost immediately - with a bad compiler flag -

root at x064:[/data/prj/samba/samba-4.7.0rc3]make V=1
WAF_MAKE=1 python ./buildtools/bin/waf build
Waf: Entering directory `/data/prj/samba/samba-4.7.0rc3/bin'
     Selected embedded Heimdal build
[ 477/3656] Compiling lib/replace/test/testsuite.c
20:06:46 runner /usr/vacpp/bin/xlc_r -Wno-format-zero-length -fPIC 
-D_REENTRANT -D_POSIX_PTHREAD_SEMANTICS 
-DSTATIC_replace_test_MODULES=NULL 
-DSTATIC_replace_test_MODULES_PROTO=extern void 
__replace_test_dummy_module_proto(void) -Idefault/lib/replace 
-I../lib/replace -Idefault/include/public -I../include/public 
-Idefault/source4 -I../source4 -Idefault/lib -I../lib 
-Idefault/source4/lib -I../source4/lib -Idefault/source4/include 
-I../source4/include -Idefault/include -I../include -Idefault -I.. 
-I/usr/local/include -D_SAMBA_BUILD_=4 -DHAVE_CONFIG_H=1 -D_ALL_SOURCE=1 
-D_GNU_SOURCE=1 -D_XOPEN_SOURCE_EXTENDED=1 
../lib/replace/test/testsuite.c -c -o default/lib/replace/test/testsuite_4.o
/usr/vacpp/bin/xlc_r: 1501-210 (S) command option Wno-format-zero-length 
contains an incorrect subargument
Waf: Leaving directory `/data/prj/samba/samba-4.7.0rc3/bin'
Build failed:  -> task failed (err #40):
         {task: cc testsuite.c -> testsuite_4.o}
Makefile:8: recipe for target 'all' failed
make: *** [all] Error 1
root at x064:[/data/prj/samba/samba-4.7.0rc3]

If I cut/paste the command but also remove the bad flag 
(-Wno-format-zero-length) the compile is successful. But only for one file.

With 'waf' I have no idea where I should be looking for this "forced" 
gcc (guessing) flag being applied everywhere.

Hope this helps - In a later mail I'll give a report on what I did to 
get 4.4.15 to build.

Sincerely,

Michael