[PATCH] lsa4_srv: Factor out dcesrc_lsa_valid_AccountRight()
abartlet at samba.org
Sat Apr 29 21:45:22 UTC 2017
On Sun, 2017-04-30 at 06:27 +1000, Andrew Bartlett via samba-technical
> On Thu, 2017-04-27 at 22:29 -0700, Jeremy Allison wrote:
> > On Thu, Apr 27, 2017 at 10:25:10PM -0700, Jeremy Allison wrote:
> > > On Fri, Apr 28, 2017 at 07:11:55AM +1200, Andrew Bartlett via
> > > samba-technical wrote:
> > > > On Thu, 2017-04-27 at 17:28 +0200, vl--- via samba-technical
> > > > wrote:
> > > > > Hi!
> > > > >
> > > > > Push appreciated!
> > > >
> > > > Any chance of a test, so we don't regress on this again?
> > > >
> > > > Either blackbox on the indicated command, python (I find this
> > > > the
> > > > easiest way to do these nowadays) or in the lsa tests in
> > > > smbtorture?
> > >
> > > RB+ and pushed the original patch, as I've created a
> > > test for it.
> > >
> > > Please review and push the test if happy (without Volker's patch
> > > this test correctly fails, passes with it).
> > Bah. Now the correct git-am version :-). Sorry.
> Thanks for this Jeremy.
> Reviewed-by: Andrew Bartlett <abartlet at samba.org>
> I've also pushed it to autobuild.
Sadly it fails. The same tests run against nt4_dc, and it fails with:
WARNING!: ../source4/torture/rpc/samr.c:4800: r.out.result was
NT_STATUS_NO_SUCH_PRIVILEGE, expected NT_STATUS_OK: Failed to add
WARNING!: privileged user delete test failed
You can reproduce with just
make test TESTS=samr
Andrew Bartlett http://samba.org/~abartlet/
Authentication Developer, Samba Team http://samba.org
Samba Developer, Catalyst IT http://catalyst.net.nz/services/samba
More information about the samba-technical