[PATCH] libpython and pycom modules Python 3 compatible

[Lumir Balhar]

On 04/26/2017 03:28 PM, Stefan Metzmacher wrote:
> Hi Lumír,
>
> why did you change -bld.SAMBA_SUBSYSTEM('COM',...)?
> It's pure C code, we don't need this per python environment.
>
> I don't thing we need tests for pycom, it doesn't do anything useful
> currently at all.
>
> I think we could just remove source4/lib/com/pycom.c
Sorry, It is my mistake. Updated patches attached. If you decide to keep 
pycom module, you can use both of them. Otherwise, you can use only 
first one and remove pycom module.

Thank you.
>
> Given the simplicity of the PySys_PathPrepend(), I don't think
> new tests are required.
>
> Reviewed-by: me for the PySys_PathPrepend patch.
>
> Can someone review and push the attached patchset?
>
> Thanks!
> metze
>
> Am 25.04.2017 um 22:08 schrieb Lumir Balhar via samba-technical:
>> Hello.
>>
>> I ported next two modules to Python 3 compatible form. I know that newly
>> ported modules should be tested first and I would like to do it but I
>> don't know how to test them. For example, pycom module is used mainly in
>> code generated by PIDL. Writing some tests for the py_update_path()
>> function in libpython should be simple (using ctypes) but I don't know
>> if this is a good approach.
>>
>> Thank you and have a nice day.
>>
>> Lumír
>>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-python-Port-pycom-module-to-Python-3-compatible-form.patch
Type: text/x-patch
Size: 2087 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20170428/bfc345df/0002-python-Port-pycom-module-to-Python-3-compatible-form.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-python-Port-simple-libpython-module-to-Python-3-comp.patch
Type: text/x-patch
Size: 1991 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20170428/bfc345df/0001-python-Port-simple-libpython-module-to-Python-3-comp.bin>