[PATCH] Fix for Coverity finding in tfork
vl at samba.org
vl at samba.org
Tue Apr 25 19:27:50 UTC 2017
On Tue, Apr 25, 2017 at 09:43:35AM -0700, Jeremy Allison via samba-technical wrote:
> On Tue, Apr 25, 2017 at 05:53:23PM +0200, Ralph Böhme via samba-technical wrote:
> > Hi!
> >
> > Volker pointed me at a Coverity finding in tfork. Here's the (hopefully correct)
> > patch.
>
> Good catch ! LGTM. Pushed.
For the EINTR loop I like our usual pattern
do {
fd = dup2(tfork_global->status_pipe[1], 0);
} while ((fd == -1) && (errno == EINTR));
better. We can always canonicalize that with a later patch.
Volker
More information about the samba-technical
mailing list