[PATCH] Fix a Coverity finding

vl at samba.org vl at samba.org
Tue Apr 25 15:48:09 UTC 2017


Hi!

Review appreciated!

Thanks, Volker
-------------- next part --------------
From 36e08d6f8702e07a6335596497214a75b35ba8bc Mon Sep 17 00:00:00 2001
From: Volker Lendecke <vl at samba.org>
Date: Tue, 25 Apr 2017 17:32:43 +0200
Subject: [PATCH] lib: Fix CID 1405493 Error handling issues (CHECKED_RETURN)

Signed-off-by: Volker Lendecke <vl at samba.org>
---
 source3/lib/ctdbd_conn.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/source3/lib/ctdbd_conn.c b/source3/lib/ctdbd_conn.c
index c629d3c..053d1b5 100644
--- a/source3/lib/ctdbd_conn.c
+++ b/source3/lib/ctdbd_conn.c
@@ -440,7 +440,12 @@ static int ctdb_read_req(struct ctdbd_connection *conn, uint32_t reqid,
  **/
 int ctdbd_setup_fde(struct ctdbd_connection *conn, struct tevent_context *ev)
 {
-	set_blocking(conn->fd, false);
+	int ret;
+
+	ret = set_blocking(conn->fd, false);
+	if (ret == -1) {
+		return errno;
+	}
 
 	conn->fde = tevent_add_fd(ev,
 				  conn,
-- 
2.1.4



More information about the samba-technical mailing list