[PATCH] fix the build of group policy cses after init fn changes

[Günther Deschner]

Hi Jeremy,

these modules are currently only compiled when explicitly selected, like
via: "--with-shared-modules=gpext_security,gpext_registry,gpext_scripts"

Thanks!
Guenther

On 24/04/17 18:34, Jeremy Allison via samba-technical wrote:
> On Mon, Apr 24, 2017 at 02:19:14PM +0200, Günther Deschner via samba-technical wrote:
>> Correct patch added now, sorry. Thanks Andreas for pointing out the
>> missing talloc_context :)
>>
>> Thanks,
>> Guenther
>>
>> On 24/04/17 13:28, Günther Deschner via samba-technical wrote:
>>> Hi,
>>>
>>> the three group policy client side extensions (not built by default) did
>>> not compile anymore after the recent init function signature changes.
>>>
>>> Please review and push.
> 
> Thanks Guenther ! What waf-magic is used to build these,
> so I can catch problems with any other changes I might
> have to make here ?
> 
> Jeremy.
> 
>> Günther Deschner                    GPG-ID: 8EE11688
>> Red Hat                         gdeschner at redhat.com
>> Samba Team                              gd at samba.org
> 
>> From a396d83213e3ce361404727c0f71ca3a27d9a0a2 Mon Sep 17 00:00:00 2001
>> From: =?UTF-8?q?G=C3=BCnther=20Deschner?= <gd at samba.org>
>> Date: Mon, 24 Apr 2017 13:25:41 +0200
>> Subject: [PATCH] s3-libgpo: Fix the build of the group policy CSEs
>>
>> Guenther
>>
>> Signed-off-by: Guenther Deschner <gd at samba.org>
>> ---
>>  source3/libgpo/gpext/registry.c | 2 +-
>>  source3/libgpo/gpext/scripts.c  | 2 +-
>>  source3/libgpo/gpext/security.c | 2 +-
>>  3 files changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/source3/libgpo/gpext/registry.c b/source3/libgpo/gpext/registry.c
>> index a24485c..088701a 100644
>> --- a/source3/libgpo/gpext/registry.c
>> +++ b/source3/libgpo/gpext/registry.c
>> @@ -407,7 +407,7 @@ static struct gp_extension_methods registry_methods = {
>>  /****************************************************************
>>  ****************************************************************/
>>  
>> -NTSTATUS gpext_registry_init(void)
>> +NTSTATUS gpext_registry_init(TALLOC_CTX *mem_ctx)
>>  {
>>  	NTSTATUS status;
>>  
>> diff --git a/source3/libgpo/gpext/scripts.c b/source3/libgpo/gpext/scripts.c
>> index 7471fb8..3f2c514 100644
>> --- a/source3/libgpo/gpext/scripts.c
>> +++ b/source3/libgpo/gpext/scripts.c
>> @@ -462,7 +462,7 @@ static struct gp_extension_methods scripts_methods = {
>>  /****************************************************************
>>  ****************************************************************/
>>  
>> -NTSTATUS gpext_scripts_init(void)
>> +NTSTATUS gpext_scripts_init(TALLOC_CTX *mem_ctx)
>>  {
>>  	NTSTATUS status;
>>  
>> diff --git a/source3/libgpo/gpext/security.c b/source3/libgpo/gpext/security.c
>> index dda58d3..3650f4c 100644
>> --- a/source3/libgpo/gpext/security.c
>> +++ b/source3/libgpo/gpext/security.c
>> @@ -277,7 +277,7 @@ static struct gp_extension_methods security_methods = {
>>  /****************************************************************
>>  ****************************************************************/
>>  
>> -NTSTATUS gpext_security_init(void)
>> +NTSTATUS gpext_security_init(TALLOC_CTX *mem_ctx)
>>  {
>>  	NTSTATUS status;
>>  
>> -- 
>> 2.9.3
>>
> 
> 
> 
> 


-- 
Günther Deschner                    GPG-ID: 8EE11688
Red Hat                         gdeschner at redhat.com
Samba Team                              gd at samba.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 201 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20170425/6f9690dd/signature.sig>