[PATCH] copy-chunk fails if src and dst file are on different tcons
jra at samba.org
Fri Apr 21 21:21:41 UTC 2017
On Fri, Apr 21, 2017 at 06:39:38PM +0200, Ralph Böhme via samba-technical wrote:
> On Fri, Apr 21, 2017 at 04:52:10PM +0200, Ralph Böhme wrote:
> > On Fri, Apr 21, 2017 at 12:55:55PM +0200, Ralph Böhme via samba-technical wrote:
> > > Hi!
> > >
> > > As the subject says, this fails against Samba but works against
> > > Windows. Verified against Windows 2016.
> > >
> > > Attached is a possible fix plus test.
> > >
> > > Please review & push if happy. Thanks!
> > please ignore for now. metze raised an issue over private RPC dealing with the
> > VFS handles that we end up using in the send functions.
> metze, maybe we can just do the check at the vfs layer. See attached patch for
> the basic idea. Should be expanded to cover all vfs functions that take a fsp
> and a vfs handle.
> Just fetching and "looking" at an fsp at the smb layer should be possible, it's
> where we start using it where we should check. Or am I still missing something?
Just my 2cents. This looks like the right approach but does mean
changing all of the fsp-based VFS calls. Is there
any way to do this above the VFS layer (haven't thought too
deeply about this yet) ?
More information about the samba-technical