[PATCH] two corner case fixes to shadow_copy2

[Jeremy Allison]

On Thu, Apr 20, 2017 at 03:25:13PM +0530, Anoop C S via samba-technical wrote:
> On Tue, 2017-04-11 at 11:27 -0700, Jeremy Allison via samba-technical wrote:
> > On Tue, Apr 11, 2017 at 12:53:25PM +0200, Michael Adam via samba-technical wrote:
> > > Hi all,
> > > 
> > > we are hitting a regression with Samba 4.6 and the
> > > combination of the shadow_copy2 and glusterfs vfs
> > > modules.
> > > 
> > > It seems to have been introduced by the patches of
> > > https://bugzilla.samba.org/show_bug.cgi?id=12531
> > > 
> > > It's my fault that I did not notice the patches
> > > and the request for review at that time... :-)
> > > 
> > > I still need to do more analysis and testing,
> > > but it seems that there are two corner cases
> > > that are at least hit when using the glusterfs
> > > vfs module that mimicks the share root to "/":
> > > 
> > > 1) make_relative_path does not treat the
> > >    case of cwd == "/" correctly.
> > > 
> > > 2) shadow_copy2_strip_snapshot does not treat the
> > >    corner case where the name only consists of
> > >    "/" followed by the @GMT-token correctly.
> > > 
> > > These corner cases are not coverered by our
> > > test cases, and as I said, I need to do more
> > > testing (e.g. if this is all), but attached find
> > > two patches that fix the above corner cases
> > > in a rahter obvious way.
> > > 
> > > Thanks for review...
> > 
> > Yep, good catch. Wish you'd found these
> > earlier (I did ask :-). Never mind, better
> > late than never.
> > 
> > RB+. Pushed, with an update to the comments
> > inline.
> > 
> 
> I have filed https://bugzilla.samba.org/show_bug.cgi?id=12743 for backporting the fixes. Can we have
> those cherry-picked backports attached to the bug?

Yes, but that is something you can do yourself you know :-).