[PATCH] some cleanups for smbldap.c

Alexander Bokovoy ab at samba.org
Wed Apr 19 14:41:48 UTC 2017

On ke, 19 huhti 2017, vl--- via samba-technical wrote:
> Hi!
> The main focus is to make "struct smbldap_state" private to smbldap.c
> for better encapsulation.
> Review appreciated!
Looks good to me. This will break ipasam in FreeIPA but I already
started moving it to own private struct as 'struct ldapsam_privates' is
not accessible anymore and I neeed anyway to implement some more of a
backend code that needs own proper private struct. Updating it to use
your wrappers is not a problem.

Please do not remove getter/setter for paged results, this is useful.


/ Alexander Bokovoy

More information about the samba-technical mailing list