[PATCH] Cleanup - remove unused functionality. -- OpenChange break
jra at samba.org
Tue Apr 18 18:05:52 UTC 2017
On Tue, Apr 18, 2017 at 08:46:48PM +0300, Alexander Bokovoy wrote:
> On ti, 18 huhti 2017, Jeremy Allison via samba-technical wrote:
> > More removal of talloc_autofree_context()
> > from completely unused code.
> > I'm planning to remove this entirely from
> > our codebase so we can make a start on adding
> > threaded code into Samba.
> > Please review and push if happy !
> I'm slightly worried about removal of the lpcfg_register_defaults_hook()
> and friends. Sure, Openchange seems to be dead but people still use
> Zentyal's fork which was updated a year ago.
> I hope anyone who still cares about Openchange/Zentyal version would
> speak up here. If not, then be it.
Just to be blunt. Zentyal is a commercial company that sells
a distro that uses our code as part of it.
There's nothing wrong with that, all of our vendors do
much the same thing and may of them employ us (which
I'm sure you'll agree is a good thing :-).
However, Zentyal is the only company that currently has moved
the technical debt of maintaining changes for their product
into our code, not a private fork that they must maintain.
Isilon did the same thing with their changes to
our VFS to support their OneFS filesystem, and
in retrospect that was a mistake.
After Isilon moved off the Samba codebase we were
able to remove their custom code from Samba.
We need to do the same thing here. If this change
is essential for Zentyal then it has to be a private
patch that they carry, not something that prevents
modernizing our code.
Hope that explains why I want you to RB+ this
patch and push it :-).
More information about the samba-technical