[PATCH] Add a simple test to verify pam_winbind can authenticate a user

[Uri Simchoni]

On 04/12/2017 10:59 AM, Andreas Schneider wrote:
> On Wednesday, 12 April 2017 09:37:59 CEST Uri Simchoni wrote:
>> On 04/12/2017 10:29 AM, Andreas Schneider wrote:
>>> On Wednesday, 12 April 2017 09:25:02 CEST Uri Simchoni wrote:
>>>> On 04/10/2017 08:51 AM, Andreas Schneider wrote:
>>>>> On Saturday, 8 April 2017 19:53:41 CEST Uri Simchoni wrote:
>>>>>> On 04/05/2017 06:41 PM, Andreas Schneider via samba-technical wrote:
>>>>>>> Hi,
>>>>>>>
>>>>>>> attached is a patch which uses pam_wrapper [1] to add at least a
>>>>>>> simple
>>>>>>> test for pam_winbind.
>>>>>>>
>>>>>>> I don't have more time to work on that right now. I hope other will
>>>>>>> help
>>>>>>> extending it. As you can see a simple PAM test is basically just 3
>>>>>>> lines
>>>>>>> of
>>>>>>> code.
>>>>>>>
>>>>>>>
>>>>>>> Review and push much appreciated!
>>>>>>>
>>>>>>>
>>>>>>> Thanks,
>>>>>>>
>>>>>>> 	Andreas
>>>>>>>
>>>>>>> [1] https://cwrap.org/pam_wrapper.html
>>>>>>
>>>>>> That landed and broke my build after successful configure because I
>>>>>> didn't have pam-devel installed.
>>>>>
>>>>> Could you try with this patch?
>>>>>
>>>>> 	Andreas
>>>>
>>>> Nope. still failed. Adding/squashing the attached is one way to go...
>>>>
>>>> Thanks,
>>>> Uri.
>>>
>>> I think this should be a patch on its own.
>>
>> Well, In that case I can RB+ your patch, and here's the same patch with
>> a better commit message. It doesn't change behavior a bit, but not in a
>> surprising manner :)
> 
> RB+
> 
> Can you push both patches?
> 
> 
> Thanks,
> 
> 
> 	Andreas
> 
Done.
Thanks,
Uri.