RFC: new testparam check
Noel Power
nopower at suse.com
Wed Apr 12 07:38:54 UTC 2017
On 11/04/17 17:53, David Disseldorp via samba-technical wrote:
> On Tue, 11 Apr 2017 17:33:19 +0100, Noel Power via samba-technical wrote:
>
>> + valid_values = str_list_make_v3_const(NULL,
>> + DEFAULT_NAME_RESOLVE_ORDER,
>> + NULL);
>> + if (!valid_values) {
>> + DBG_ERR("OOM: failed to make string list from %s\n",
>> + DEFAULT_NAME_RESOLVE_ORDER);
>> + return false;
>> + }
>> + values_to_set = str_list_make_v3_const(lp_ctx->globals->ctx,
>> + pszParmValue,
>> + NULL);
>> + if (!values_to_set) {
>> + DBG_ERR("OOM: failed to make string list from %s\n",
>> + pszParmValue);
> valid_values should be freed on failure here.
/me face palms,
knew it was a bad idea to do this while running out the door, I'll post
an updated patch later on this morning
Noel
More information about the samba-technical
mailing list