[PATCH] Add a simple test to verify pam_winbind can authenticate a user

[Uri Simchoni]

On 04/10/2017 08:51 AM, Andreas Schneider wrote:
> On Saturday, 8 April 2017 19:53:41 CEST Uri Simchoni wrote:
>> On 04/05/2017 06:41 PM, Andreas Schneider via samba-technical wrote:
>>> Hi,
>>>
>>> attached is a patch which uses pam_wrapper [1] to add at least a simple
>>> test for pam_winbind.
>>>
>>> I don't have more time to work on that right now. I hope other will help
>>> extending it. As you can see a simple PAM test is basically just 3 lines
>>> of
>>> code.
>>>
>>>
>>> Review and push much appreciated!
>>>
>>>
>>> Thanks,
>>>
>>> 	Andreas
>>>
>>> [1] https://cwrap.org/pam_wrapper.html
>>
>> That landed and broke my build after successful configure because I
>> didn't have pam-devel installed.
> 
> 
> Could you try with this patch?
> 
> 
> 	Andreas
> 
Nope. still failed. Adding/squashing the attached is one way to go...

Thanks,
Uri.
-------------- next part --------------
From 6a153a86dad63235eb5c22ea8e016994f0049d51 Mon Sep 17 00:00:00 2001
From: Uri Simchoni <uri at samba.org>
Date: Wed, 12 Apr 2017 07:19:01 +0000
Subject: [PATCH] waf: fixup building without pam

Signed-off-by: Uri Simchoni <uri at samba.org>
---
 source3/wscript | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/source3/wscript b/source3/wscript
index 7875368..c526fc5 100644
--- a/source3/wscript
+++ b/source3/wscript
@@ -947,6 +947,10 @@ int i; i = PAM_RADIO_TYPE;
         if use_pam:
             conf.DEFINE('WITH_PAM', 1)
             conf.DEFINE('WITH_PAM_MODULES', 1)
+        else:
+            conf.fatal("PAM support is enabled but prerequisite libraries "
+                       "or headers not found. Use --without-pam to disable "
+                       "PAM support.");
 
     seteuid = False
 
-- 
2.9.3