RFC: new testparam check

David Disseldorp ddiss at suse.de
Tue Apr 11 11:37:23 UTC 2017


On Tue, 11 Apr 2017 12:26:26 +0100, Noel Power via samba-technical wrote:

> On 11/04/17 12:08, Andreas Schneider wrote:
> > On Tuesday, 11 April 2017 12:42:59 CEST Noel Power via samba-technical wrote:  
> >> Hi,
> >>
> >> Had a situation where a customer had a weird problem, after much head
> >> scratching and debugging it turned out to be a typo in one of the values
> >> in 'name resolve order' causing the problem. Really would have helped
> >> save alot of time if testparam complained especially as the values for
> >> this param should be from a known set of valid values. I'll happily open
> >> a samba bug and update the the patch to reflect that and any other
> >> comments/issues if this is useful. Thoughts ?  
> > RB+ ;-)
> >  
> ok, since at least 1 person thinks it's useful here is a version with a
> bug # :->>

Please add a test for this to ./source3/script/tests/test_testparm_s3.sh
Otherwise, this looks good to me too.


Cheers, David



More information about the samba-technical mailing list