[PATCH] small test for Bug 12558

Jeremy Allison jra at samba.org
Mon Apr 10 18:00:19 UTC 2017

On Mon, Apr 10, 2017 at 10:52:28AM -0700, Richard Sharpe via samba-technical wrote:
> On Mon, Apr 10, 2017 at 9:54 AM, Jeremy Allison via samba-technical
> <samba-technical at lists.samba.org> wrote:
> > On Mon, Apr 10, 2017 at 02:40:23PM +0200, vl--- via samba-technical wrote:
> >> Hi!
> >>
> >> Before we enter a flamewar about 80 cols vs proper shell coding style
> >> I think we could also opt to just not use this patch and cross fingers
> >> that next time this bug does not happen.
> >
> > 80+ cols is a C code restriction, not a shell code one.
> All animals are equal but some are more equal than others ...

Rubbish Richard. C code is deep Samba logic, one mistake
in which can lead to a root-level-remote code execution
security CVE.

Shell code is test code.

One I really care about simplicity and clarity, the
other - so long as it works and tests the C code ... :-).

More information about the samba-technical mailing list