[PATCH] allow passdb backend to change trusted domain object password with clear text

Andrew Bartlett abartlet at samba.org
Mon Apr 10 11:38:24 UTC 2017


On Mon, 2017-04-10 at 10:22 +0300, Alexander Bokovoy wrote:
> On pe, 07 huhti 2017, Jeremy Allison wrote:
> > On Fri, Apr 07, 2017 at 11:08:44PM +0300, Alexander Bokovoy wrote:
> > 
> > > I'll see what I can do there but this code is a copy/paste from
> > > another
> > > helper we have for NT/LM hash pass-through. Guenther already
> > > asked me to
> > > consider how I can going these two functions in a common piece
> > > that
> > > could be called for both cases, so I'll do refactoring for this
> > > too.
> > 
> > Thanks. That other code might be wrong too :-).
> 
> Attached is the patch that unifies NT hash/plain text pass-through.
> This is a more concise change that doesn't duplicate existing code.

How certain are we that our plaintext password is null terminated?

+	cr.creds.password = (const char*) plaintext.data;

Thanks,

Andrew Bartlett
-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba




More information about the samba-technical mailing list