Patch to add support for advertising FULLSYNC to Mac OSX Clients
jra at samba.org
Fri Apr 7 20:27:38 UTC 2017
On Fri, Apr 07, 2017 at 10:14:53PM +0200, Ralph Böhme wrote:
> On Fri, Apr 07, 2017 at 10:40:00PM +0300, Uri Simchoni via samba-technical wrote:
> > I think I'm back to b) with this, as:
> > - There's no way to really hide this special flush behavior, as aapl
> > mode affects how you parse packets.
> > - Even if there was a way, the abstraction is wrong - you don't ask your
> > file system how to interpret packets.
> > So, with this flush I would have a *global* (smbd_server_connection)
> > flag that we're running AAPL, and maybe move AAPL parsing from vfs_fruit
> > to smb layer, make it a first citizen. Making it global serves two things:
> > 1. Keeps files_struct from bloating
> > 2. More correct as AAPL mode is global
> I tend to agree.
> > For file index, I would *remove* the global aapl_zero_file_id flag, and
> > hide *that* in the VFS (SMB_VFS_GET_FILE_ID), because it's a good
> > abstraction with potential uses elsewhere.
> > So with this, I don't yet see a use case for VFS_QUERY_FEATURE()...
> RIP. :)
Fair enough, so long as we can get the aapl-flags out
of files_struct, I'll be much happier :-).
More information about the samba-technical