[PATCH] Re: Proposed ldb 1.1.30 and tdb 1.3.13 (improve AD DC search performance, make multi-process)

Andrew Bartlett abartlet at samba.org
Wed Apr 5 00:19:22 UTC 2017


On Mon, 2017-04-03 at 23:48 +1200, Andrew Bartlett via samba-technical
wrote:
> On Mon, 2017-04-03 at 13:04 +0200, Stefan Metzmacher wrote:
> > Hi Andrew,
> > 
> > > Attached is a patch series to bump up the ldb and tdb version
> > > numbers
> > > with important fixes for performance, resulting from the locking
> > > work
> > > discussed in the other thread, and the performance improvements
> > > found
> > > by using Samba's binary search over the list of attributes with
> > > an
> > > index.
> > > 
> > > You will no doubt want to carefully consider the tdb patches
> > > along
> > > with
> > > the rest of the team, and asked to be the one to push the ldb
> > > changes
> > > so you could tag the release.
> > > 
> > > This passes a private autobuild.
> > > 
> > > Please let me know if there is anything else I can do to assist.
> > 
> > Please retry again with --stdout :-)
> 
> :-)
> 
> http://git.catalyst.net.nz/gw?p=samba.git;a=shortlog;h=refs/heads/ldb
> -1
> .1.30-for-metze

Attached is the whole set of patches I'm currently trying to land, as
well as just the set discussed.  I've improved the whitespace.

The end purpose I'm trying to end up with is the AD DC set to use
multiple processes for LDAP, and fixing up the locking issues, so that
is more practical.  I've written tests to show where becoming multi-
process costs, and where it helps, and I'm happy with the trade-off.  

The attached graph illustrates it well.  (Run on my workstation, so
fairly noisy.  I may be able to get better graphs later). 

For the multi-process, the worst case is when one client connects,
binds, searches for one thing and drops the socket, but this is a
pretty un-realistic workload, and once we get multiple clients this
change helps. 

Thanks,

Andrew Bartlett
-- 
Andrew Bartlett
https://samba.org/~abartlet/
Authentication Developer, Samba Team         https://samba.org
Samba Development and Support, Catalyst IT   
https://catalyst.net.nz/services/samba



-------------- next part --------------
A non-text attachment was scrubbed...
Name: ldb-1.1.30-for-metze.patch
Type: text/x-patch
Size: 59527 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20170405/a2fcb774/ldb-1.1.30-for-metze-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: multi-process-ldap-server.patch
Type: text/x-patch
Size: 74710 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20170405/a2fcb774/multi-process-ldap-server-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: multi-process-ldap-server.pdf
Type: application/pdf
Size: 67629 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20170405/a2fcb774/multi-process-ldap-server-0001.pdf>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: multi-process-ldap-server-abs.pdf
Type: application/pdf
Size: 66564 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20170405/a2fcb774/multi-process-ldap-server-abs-0001.pdf>


More information about the samba-technical mailing list