[PATCH] TDB traverse lock changes for massive AD DC perf improvement

Andrew Bartlett abartlet at samba.org
Tue Apr 4 23:50:16 UTC 2017


On Wed, 2017-04-05 at 10:42 +1200, Andrew Bartlett wrote:
> On Sat, 2017-04-01 at 18:44 +1300, Andrew Bartlett via samba-
> technical
> wrote:
> > 
> > Aside from a good delay so others can comment, what would you
> > recommend
> > I do next towards progressing this patch?
> 
> Can I please get a good eye over and a team review for this patch?
> 
> Thanks,
> 
> Andrew Bartlett

The attached patch takes on board the 80 column feedback (I've also
found an emacs mode that is helpful but unobtrusive). 

I hope this meets with your approval, as it makes a massive difference
to our Samba AD DC performance.

Please review.  If reviewed, I'll push with a patch that adds new
performance tests that I'm keen to get in. 

Thanks,

Andrew Bartlett

-- 
Andrew Bartlett
https://samba.org/~abartlet/
Authentication Developer, Samba Team         https://samba.org
Samba Development and Support, Catalyst IT   
https://catalyst.net.nz/services/samba



-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-tdb-Improve-debugging-when-the-allrecord-lock-fails-.patch
Type: text/x-patch
Size: 2175 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20170405/791deec5/0001-tdb-Improve-debugging-when-the-allrecord-lock-fails-.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-tdb-Remove-locking-from-tdb_traverse_read.patch
Type: text/x-patch
Size: 4384 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20170405/791deec5/0002-tdb-Remove-locking-from-tdb_traverse_read.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-tdb-Improve-debugging-in-_tdb_transaction_start.patch
Type: text/x-patch
Size: 879 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20170405/791deec5/0003-tdb-Improve-debugging-in-_tdb_transaction_start.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-tdb-Release-version-1.3.13.patch
Type: text/x-patch
Size: 5263 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20170405/791deec5/0004-tdb-Release-version-1.3.13.bin>


More information about the samba-technical mailing list