Re: [PATCH] winbindd: lookup-domain for well-known SIDs on a DC

Uri Simchoni uri at
Tue Apr 4 18:23:25 UTC 2017

On 04/04/2017 01:50 PM, Ralph Böhme via samba-technical wrote:
> On Sun, Apr 02, 2017 at 05:10:02PM +0200, Ralph Böhme wrote:
>> On Sat, Apr 01, 2017 at 11:26:09PM +0000, Jeremy Allison wrote:
>>> On Sat, Apr 01, 2017 at 11:40:23PM +0200, Ralph Böhme wrote:
>>>> review_cancel_send()
>>>> Please take a look at the patch I just sent in reply to Rowland's mail. It
>>>> contains a shellscript level fix for one of the tests.
>>> Oh sorry, I already pushed your first patch. Sorry Rowland,
>>> didn't catch the error in review.
>>> Ralph, do you want to rebase on top of what's in master
>>> already and just send a fix for the test ?
>> attached.
>> I'm adding an additional patch under the same bug number, spotted this while
>> continuing to fight with the sids2xids code.
> just in case this one got lost... *ping*
> Thanks!
> -slow
I think we had a mid-air collision with patch 1/2 - see 4/6 in my v2
patch for the SID history and tell me what you think...

RB+ on the test

(BTW, if I understand correctly, the exist status has no impact on the
outcome of "make test" - it's the subunit output that matters, but we
generate a return status for out-of-make-test execution).


More information about the samba-technical mailing list