[ADDITIONAL PATCH][BUG 12721] Cleanup directories correctly in the smbclient test

Andreas Schneider asn at samba.org
Tue Apr 4 09:19:34 UTC 2017


as I'm the only one who runs 'make test' on other distributions than on Ubuntu 
I'm always the one finding the ugly stuff ;-)

UNEXPECTED(failure): samba3.blackbox.smbclient_s3.sign (nt4_dc).follow 
symlinks = no(nt4_dc)
REASON: Exception: Exception: CLI_FORCE_INTERACTIVE=yes /home/asn/workspace/
projects/samba/bin/smbclient -Uasn%localntdc2pass //LOCALNT4DC2/nosymlinks -I --configfile=/home/asn/workspace/p
rojects/samba/st/client/client.conf --signing=required
NT_STATUS_ACCESS_DENIED opening remote file \source
CLI_FORCE_INTERACTIVE=yes /home/asn/workspace/projects/samba/bin/smbclient -
Uasn%localntdc2pass //LOCALNT4DC2/nosymlinks -I --configfile=/home/
.conf --signing=required
CLI_FORCE_INTERACTIVE=yes /home/asn/workspace/projects/samba/bin/smbclient -
Uasn%localntdc2pass //LOCALNT4DC2/nosymlinks -I --configfile=/home/
.conf --signing=required
NT_STATUS_FILE_IS_A_DIRECTORY opening remote file \foo\bar\testfile

The attached patch creates a test directory in the share and removes that 
directory completely so nothing is left behind and can interfere in another 

It makes sure sub-directories are created and the files get some content. 
'touch' is not the best solution to create files.

I found this on openSUSE Tumbleweed and the attached patch allows the test to 
pass on that distribution now.

It only happend when I run all the tests using:
make -j test TESTS="samba3.blackbox.smbclient_s3"

Review much appreciated.



Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             asn at samba.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-s3-tests-Create-a-test-directory-for-a-clean-test.patch
Type: text/x-patch
Size: 2736 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20170404/f2982710/0001-s3-tests-Create-a-test-directory-for-a-clean-test.bin>

More information about the samba-technical mailing list