On code formatting (and testing)

Jeremy Allison jra at samba.org
Mon Apr 3 19:30:14 UTC 2017

On Tue, Apr 04, 2017 at 07:20:28AM +1200, Andrew Bartlett wrote:
> No, that way we end up with a dog's breakfast. 
> New files, substantial rewrites, fine!  Improving totally unreadable
> code prior to starting, reasonable!  Mixing old and new style line-by-
> line, really?

Yep. We're going to have to agree to disagree on that one then :-).

> That is why I've always opposed rules 'for new code' that don't come
> with patches making at least a majority of our existing code comply. 
> We have seen how to do that well with the work Garming did early in his
> time to expand some of the hidden return macros. 
> Now, there is something I do feel as passionate about, and that is the
> amount of 'obviously correct' code that lands without tests.  We have a
> great record in Samba for automated testing, but I do wish we had as
> much zeal for comprehensive unit and integration tests as we do for
> patch-perfecting.  

Now *that's* something we can both agree on :-).

> All things in moderation?

Even moderation itself ? :-) :-).

More information about the samba-technical mailing list