[PATCH] winbindd: error handling in rpc_try_lookup_sids3()
asn at samba.org
Mon Apr 3 13:16:45 UTC 2017
On Sunday, 2 April 2017 17:11:34 CEST Ralph Böhme via samba-technical wrote:
> On Sat, Apr 01, 2017 at 08:48:06PM -0700, Jeremy Allison wrote:
> > On Sat, Apr 01, 2017 at 10:53:24PM +0200, Ralph Böhme wrote:
> > > On Sat, Apr 01, 2017 at 02:21:14PM +0200, Ralph Böhme wrote:
> > > > On Fri, Mar 31, 2017 at 04:08:36PM -0700, Jeremy Allison wrote:
> > > > > Also, the function below:
> > > > >
> > > > > rpc_lookup_sids() has exactly the same logic as that
> > > > > in rpc_try_lookup_sids3(). Should we do the same
> > > > > change there ? If not, why not ?
> > > >
> > > > Yes, there are more places where it's done wrong:
> > > > winbindd_lookup_sids() and dcerpc_lsa_lookup_sids_noalloc().
> > > >
> > > > Let's see what happens when I try to fix those as well... :)
> > >
> > > ok, so how about this one? Fixes all lookupsids and lookupsids3 callers,
> > > adding a new macro NT_STATUS_LOOKUP_ERR. It just passed a private
> > > autobuild.
> > >
> > > I don't really think the macro name is a good choice, but I couldn't
> > > come up with something else? Suggestions? It could be used for LSA and
> > > SAMR SID and name lookups.
> > I don't like it either, but it's not easy to think of
> > good names. RB+. Pushed, and we can update later if
> > we think of a better name :-).
> Looks like this one never hit autobuild? Or failed?
I had the same lately, I pushed job to autobuild and after some time the build
simply vanished. No build error mail!
Andreas Schneider GPG-ID: CC014E3D
Samba Team asn at samba.org
More information about the samba-technical