ldb cmocka tests

Andrew Bartlett abartlet at samba.org
Mon Apr 3 02:57:23 UTC 2017

Some more review!

In ldb:tests: Build a ldb test for the tdb backend

Can you clarify this hunk:

+    conf.SET_TARGET_TYPE('cmocka', 'EMPTY')
+    conf.env.found_cmocka = False
+    if conf.CHECK_CFG(package='cmocka',
+                      args='"cmocka >= 1.1.0" --cflags --libs',
+                      msg='Checking for cmocka >= 1.1.0'):
+        conf.CHECK_LIB('cmocka', shlib=True)
+        #conf.CHECK_FUNCS_IN('_cmocka_run_group_tests', 'cmocka')
+        conf.env.found_cmocka = True

I'm presuming we should drop this line:
#conf.CHECK_FUNCS_IN('_cmocka_run_group_tests', 'cmocka')

In "ldb:tests: Add a test for ldb transactions" I hate to have to
comment on whitespace given recent discussions, but this isn't using
our standard 8-space tabs, and (even more importantly) isn't in line
with the rest of the file. 

In "ldb:tests: unit test for ldb_search()" it really should check both
with and without the checkBaseOnSearch attribute on @OPTIONS, as this
changes the behaviour quite a bit.

In "ldb:tests: Unit test the ldb_rename() operation" I agree with the
FIXME, the rename with no change case really should be checked. 

In "ldb:tests: Print subunit output", should we include this in the
Samba test as well?  Otherwise, I'm not sure what the point of the
subunit output is, as ldb is currently only using the return value. 

In any case, the tests fail with:
Python testsuite returned 0
test: test_connect
success: test_connect
test: (null)
Makefile:15: recipe for target 'test' failed
make: *** [test] Error 134

for me.

Finally, we probably should get current cmocka on sn-devel before we
push this. 


Andrew Bartlett

More information about the samba-technical mailing list