[PATCH] Fix intermittent crash in NTVFS server.

Jeremy Allison jra at samba.org
Sat Apr 1 23:20:34 UTC 2017


On Sat, Apr 01, 2017 at 11:47:38PM +0200, Ralph Böhme wrote:
> On Sat, Apr 01, 2017 at 05:27:00PM +0000, Jeremy Allison wrote:
> > ... NC-17 ...
> >
> > Re-ordering this to explicitly call talloc_free(srv_conn) first
> > and then model_ops->terminate() fixes this problem.
> 
> lgtm. I think the talloc_free(srv_conn) should be a TALLOC_FREE(srv_conn), but
> if you like to push as is with my review, feel free.

Good call. Changed and pushed with your RB+. Thanks.



More information about the samba-technical mailing list