[PATCH] Fix intermittent crash in NTVFS server.

Ralph Böhme slow at samba.org
Sat Apr 1 21:47:38 UTC 2017


On Sat, Apr 01, 2017 at 05:27:00PM +0000, Jeremy Allison wrote:
> ... NC-17 ...
>
> Re-ordering this to explicitly call talloc_free(srv_conn) first
> and then model_ops->terminate() fixes this problem.

lgtm. I think the talloc_free(srv_conn) should be a TALLOC_FREE(srv_conn), but
if you like to push as is with my review, feel free.

Cheerio!
-slow



More information about the samba-technical mailing list