Another user at realm type issue/bug

Andreas Schneider asn at samba.org
Thu Sep 29 21:14:29 UTC 2016


On Thursday, 29 September 2016 12:28:20 CEST Jeremy Allison wrote:
> On Thu, Sep 29, 2016 at 07:22:28PM +0100, Noel Power wrote:
> > On 29/09/16 18:54, Jeremy Allison wrote:
> > > On Thu, Sep 29, 2016 at 06:10:55PM +0100, Noel Power wrote:
> > >> Hi,
> > >> 
> > >> When looking at the parse_domain_user issue with user at realm credentials
> > >> I was playing around with smbtorture and noticed that the
> > >> cli_credentials.username field is not setup when using -Uuser at realm
> > >> with
> > >> smbtorture, this seems like a bug to me, please see that attached patch
> > > 
> > > Shouldn't this just be removing the "return;" ?
> > > 
> > > The 'goto done' and new done: label is redundent here.
> > 
> > doh! /me face palms
> > you are completely correct :-)
> > 
> > here's v2
> 
> Reviewed-by: Jeremy Allison <jra at samba.org>.
> 
> Can I get a second Team reviewer ?

RB+

Thanks for catching this!




More information about the samba-technical mailing list