[PATCHES] Fix idmap_ad for clustered Samba (BUG 12295)

Jeremy Allison jra at samba.org
Wed Sep 28 19:44:23 UTC 2016


On Tue, Sep 27, 2016 at 12:16:55PM -0700, Christof Schmitt wrote:

Patch #2 Reviewed-by: Jeremy Allison <jra at samba.org>

Pushed. Patch #1 I'm still reviewing (might need
some help on that one :-).

> From 71dd086fe2e76e8c761176ca486988a0b28e002a Mon Sep 17 00:00:00 2001
> From: Christof Schmitt <cs at samba.org>
> Date: Mon, 26 Sep 2016 14:27:28 -0700
> Subject: [PATCH 2/2] winbind: Fix passing idmap failure from wb_sids2xids back
>  to callers
> 
> If the idmap call in wb_sids2xids fails, the callers expect xid.type to
> be set to ID_TYPE_NOT_SPECIFIED, not the internal type field that is
> initialized from the lookupsids call.
> 
> BUG: https://bugzilla.samba.org/show_bug.cgi?id=12295
> 
> Signed-off-by: Christof Schmitt <cs at samba.org>
> ---
>  source3/winbindd/wb_sids2xids.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/source3/winbindd/wb_sids2xids.c b/source3/winbindd/wb_sids2xids.c
> index e16917f..25260be 100644
> --- a/source3/winbindd/wb_sids2xids.c
> +++ b/source3/winbindd/wb_sids2xids.c
> @@ -305,7 +305,7 @@ static void wb_sids2xids_done(struct tevent_req *subreq)
>  		 * All we can do here is to report "not mapped"
>  		 */
>  		for (i=0; i<src->num_ids; i++) {
> -			src->ids[i].type = ID_TYPE_NOT_SPECIFIED;
> +			src->ids[i].xid.type = ID_TYPE_NOT_SPECIFIED;
>  		}
>  	}
>  
> -- 
> 1.8.3.1
> 



More information about the samba-technical mailing list