[PATCHES] SMB2 client quota support
Andreas Schneider
asn at samba.org
Tue Sep 27 14:00:29 UTC 2016
On Monday, 26 September 2016 13:05:14 CEST Jeremy Allison wrote:
> 1). Hate this reformatting... :-)
>
> [PATCH 07/19] s3-libsmb: make parse_user_quota_record() public
>
> -static bool parse_user_quota_record(const uint8_t *rdata,
> - unsigned int rdata_count,
> - unsigned int *offset,
> - SMB_NTQUOTA_STRUCT *pqt)
> +bool parse_user_quota_record(const uint8_t *rdata, unsigned int
> rdata_count, + unsigned int *offset,
> SMB_NTQUOTA_STRUCT *pqt)
>
> I much prefer the
>
> function(arg1
> arg2,
> arg3.
> arg4)
>
> style. But that's just a personal thing :-).
>
If this isn't in our CodingStyle guideline, we should add it! We prefer this,
so if you change an argument, you can directly see which argument changed in a
patch.
Cheers,
Andreas
More information about the samba-technical
mailing list