[PATCHES] use WERRORs generated from MS-ERREF and remove duplicate error definitions

[Stefan Metzmacher]

Hi Günther,

this doesn't build for me, did you compile only with --without-ad-dc ?

[1909/4258] Compiling source4/dsdb/samdb/ldb_modules/password_hash.c
In file included from ../source4/dsdb/samdb/ldb_modules/util.h:32:0,
                 from ../source4/dsdb/samdb/ldb_modules/password_hash.c:41:
../source4/dsdb/samdb/ldb_modules/password_hash.c: In function
‘setup_last_set_field’:
../source4/dsdb/samdb/ldb_modules/password_hash.c:2032:8: error:
‘WERR_INVALID_PARAM’ undeclared (first use in this function)
        WERR_INVALID_PARAM,
        ^
../source4/dsdb/common/util.h:80:56: note: in definition of macro
‘dsdb_module_werror’
  dsdb_werror_at(ldb_module_get_ctx(module), ldb_ecode, werr, \
                                                        ^
compilation terminated due to -Wfatal-errors.

Can you make sure this passes a private autobuild?

Thanks!
metze

Am 25.09.2016 um 10:07 schrieb Günther Deschner:
> Here is a new version of that patchset that compiles with the very
> recent changes in rpc_client and server.
> 
> Please review and push.
> 
> Thanks,
> Guenther
> 
> On 21/09/16 23:24, Günther Deschner wrote:
>> Hi,
>>
>> attached is a patchset that removes a lot of duplicate error definitions
>> and changes our code to only use the generated errors (from MS-ERREF).
>>
>> https://git.samba.org/?p=gd/samba/.git;a=shortlog;h=refs/heads/master-errors-v2-ok
>>
>> Please review and push,
>>
>> Thanks,
>> Guenther
>>
> 
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160925/66c6d4ea/signature.sig>