[PATCH] Remove source3/lib/events.c dependency in nmbd

Jeremy Allison jra at samba.org
Sat Sep 24 03:02:06 UTC 2016


On Fri, Sep 23, 2016 at 06:49:21PM -0700, Jeremy Allison wrote:
> On Fri, Sep 23, 2016 at 04:44:55PM -0700, Volker Lendecke wrote:
> > On Fri, Sep 23, 2016 at 12:46:28PM -0700, Jeremy Allison wrote:
> > > On Fri, Sep 23, 2016 at 11:55:11AM -0700, Jeremy Allison wrote:
> > > > Is attached. Dirty, but seems to work. Now to try
> > > > and figure out how to split it up.. :-).
> > > 
> > > OK, here's the split-up micro-commit version.
> > > 
> > > Passes make test here ! Please review and push
> > > if you're happy.
> > 
> > I've taken a look at the first one and found the attached cosmetic
> > ones. Ok if I squash them in?
> 
> Perfecty fine - thanks ! I should have known better for #1 and #2 :-)
> #3 I couldn't remember what our coding standards were (and was
> too lazy to look them up when I was working on it :-).
> 
> Please squash and push.
> 
> I can take a look at the other users of source4/lib/events.c
> if you like ?

I means source3/lib/events.c of course :-).

I have a patch that removes it now. Testing....



More information about the samba-technical mailing list