[PATCHES] Add Unix attributes to a user or group

Andrew Bartlett abartlet at samba.org
Fri Sep 23 02:07:06 UTC 2016


On Thu, 2016-09-22 at 22:20 +0100, Rowland Penny wrote:
> On Thu, 22 Sep 2016 16:13:05 -0500
> Andrew Bartlett <abartlet at samba.org> wrote:
> 
> > Regarding the modify stuff, I think the best and most consistent
> > approach for a 'samba-tool user modify' would be to have it take
> > and
> > apply the same arguments that samba-tool user create now has, and
> > then
> > work from there.  I realise that isn't interactive, but it will
> > make
> > much easier a scripted approach to testing, and we can move to
> > something interactive as a second step.
> > 
> > Does that sound reasonable?
> 
> Well it would, except that is what 'cmd_user_nis_add' does, did you
> even read it ?

That is my point, that should become a generic 'modify', that allows
all reasonable attributes to be modified (ie, the set you can specify
with add). 

That way it stops being a special-case nisadd, which I don't like.

I hope this is clearer.

Thanks,

Andrew Bartlett

-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba




More information about the samba-technical mailing list