[PATCH] Fix CTDB PID file handling

[Volker Lendecke]

Hi, Martin!

On Thu, Sep 22, 2016 at 04:04:15PM +1000, Martin Schwenke wrote:
> At the moment ctdbd_wrapper is solid but multiple ctdbd's can start at
> the same time.  If they overtake each other in interesting ways then
> one ctdbd can exit early and remove another's PID file.
> 
> Add a PID file abstraction, use it, make PID file creation the first
> action, clean up some surrounding code.
> 
> Please review and maybe push...

We have lib/util/pidfile.c. You do destruction with a talloc context,
but the locking engine is also there in lib/util/pidfile.c. It's not
rocket science, but also not entirely trivial, so -- can't we share
code here between ctdb/common and lib/util?

Volker