[PATCH] ctdb-tests: Fix typo in local daemons IPv6 setup

Amitay Isaacs amitay at gmail.com
Thu Sep 22 06:33:57 UTC 2016


On Thu, Sep 22, 2016 at 2:05 PM, Martin Schwenke <martin at meltin.net> wrote:

> On Wed, 14 Sep 2016 14:25:40 +1000, Amitay Isaacs <amitay at gmail.com>
> wrote:
>
> > On Wed, Sep 14, 2016 at 2:16 PM, Martin Schwenke <martin at meltin.net>
> wrote:
> >
> > > This should be a sub-shell not an arithmetic expansion.
> > >
> > > Of course, testing as non-root with IPv6 node addresses still doesn't
> > > work because we can't pull the stunt we do with IPv4 127.0.0.1/8
> > > addresses and loopback...  addresses still need to be added to
> > > interface by hand as root before testing.
> > >
> >
> > Let's fix the comment to add the IPs manually.
> >
> > It should mention the Node IPs and not public IPs since we don't actually
> > host public IPs.
>
> Better still, with the attached patches (1 old + 1 new), the FIXME is
> gone.  If IPv6 addresses are not on an interfaces it now prints a clear
> error message for each missing address.
>
> Please review and maybe push...
>
> peace & happiness,
> martin
>

Pushed to autobuild.

Amitay.


More information about the samba-technical mailing list