[PATCH] Fix nss_wins

[Jim McDonough]

On 09/19/2016 06:38 PM, Jim McDonough wrote:
> On 09/19/2016 06:15 PM, Jim McDonough wrote:
>> On 09/19/2016 11:32 AM, Andreas Schneider wrote:
>>> Hello,
>>>
>>> the attached patchset fixes two issues with nss_wins:
>>>
>>> https://bugzilla.samba.org/show_bug.cgi?id=12269
>>> https://bugzilla.samba.org/show_bug.cgi?id=12277
>>>
>>> Please review and push if OK.
>> Why are you giving two errno pointers?  from netdb.h:
>> extern int gethostbyname_r (const char *__restrict __name,
>>                             struct hostent *__restrict __result_buf,
>>                             char *__restrict __buf, size_t __buflen,
>>                             struct hostent **__restrict __result,
>>                             int *__restrict __h_errnop);
But, your prototype does line up with what the files and dns nss modules
do.  Sigh.  I *&$  hate nsswitch...
>> Your prototypes don't line up with this one.
>> Same comment for the gethostbyname2_r prototype...
> And in fact, this wouldn't prevent the segfaults we're already causing
> in the downstream nss modules both in fedora and opensuse
> tumbleweed...setting that pointer to point to errno instead of a
> hostent** has some bad results :-/
> 
>