[PATCH] Fix nss_wins

Jeremy Allison jra at samba.org
Mon Sep 19 22:22:25 UTC 2016


On Mon, Sep 19, 2016 at 06:15:52PM -0400, Jim McDonough wrote:
> On 09/19/2016 11:32 AM, Andreas Schneider wrote:
> > Hello,
> > 
> > the attached patchset fixes two issues with nss_wins:
> > 
> > https://bugzilla.samba.org/show_bug.cgi?id=12269
> > https://bugzilla.samba.org/show_bug.cgi?id=12277
> > 
> > Please review and push if OK.
> Why are you giving two errno pointers?  from netdb.h:
> extern int gethostbyname_r (const char *__restrict __name,
>                             struct hostent *__restrict __result_buf,
>                             char *__restrict __buf, size_t __buflen,
>                             struct hostent **__restrict __result,
>                             int *__restrict __h_errnop);
> Your prototypes don't line up with this one.
> Same comment for the gethostbyname2_r prototype...

Oops - looked right to me (sorry). I'll let you two
fight it out..



More information about the samba-technical mailing list